Allow passing schema as a Python object #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great thanks - my only comment would be is it a good idea to add a small test? |
radix0000
force-pushed
the
final_bods_0_4
branch
from
f4c874d to
56325d9
Compare
Allow the calling application to load the schema rather than flatten-tool Partial work around for: #447
radix0000
force-pushed
the
final_bods_0_4
branch
from
56325d9 to
fba9979
Compare
Contributor
Author
|
Have added some tests. |
ghost
approved these changes
Dec 18, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Think I would call it Added rather than Fixed. Fixed implies it was broken before where this is a new feature. But don't have strong views; could change in release PR too.
jpmckinney
added a commit
to open-contracting/kingfisher-collect
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the calling application to load the schema rather than flatten-tool. Partial work around for: #447
Have created a whole new using as a library section in docs, in order to mention this.